actions/act
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove the network when there is no service (#103)

Browse Source 
Reviewed-on: https://gitea.com/gitea/act/pulls/103
Reviewed-by: Jason Song <i@wolfogre.com>
Co-authored-by: Zettat123 <zettat123@gmail.com>
Co-committed-by: Zettat123 <zettat123@gmail.com>
This commit is contained in:
Zettat123
2024-03-27 10:07:29 +00:00
committed by Jason Song
parent 0054a45d1b
commit 655f578563
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
pkg/runner/run_context.go
View File

@@ -382,15 +382,15 @@ func (rc *RunContext) startJobContainer() common.Executor {
if err := rc.stopServiceContainers()(ctx); err != nil { if err := rc.stopServiceContainers()(ctx); err != nil {
logger.Errorf("Error while cleaning services: %v", err) logger.Errorf("Error while cleaning services: %v", err)
} }
if createAndDeleteNetwork { }
// clean network if it has been created by act if createAndDeleteNetwork {
// if using service containers // clean network if it has been created by act
// it means that the network to which containers are connecting is created by `act_runner`, // if using service containers
// so, we should remove the network at last. // it means that the network to which containers are connecting is created by `act_runner`,
logger.Infof("Cleaning up network for job %s, and network name is: %s", rc.JobName, networkName) // so, we should remove the network at last.
if err := container.NewDockerNetworkRemoveExecutor(networkName)(ctx); err != nil { logger.Infof("Cleaning up network for job %s, and network name is: %s", rc.JobName, networkName)
logger.Errorf("Error while cleaning network: %v", err) if err := container.NewDockerNetworkRemoveExecutor(networkName)(ctx); err != nil {
} logger.Errorf("Error while cleaning network: %v", err)
} }
} }
return nil return nil