Pass 'sleep' as container command rather than entrypoint (#86)

The current code overrides the container's entrypoint with `sleep`.  Unfortunately, that prevents initialization scripts, such as to initialize Docker-in-Docker, from running.

The change simply moves the `sleep` to the command, rather than entrypoint, directive.

For most containers of this sort, the entrypoint script performs initialization, and then ends with `$@` to execute whatever command is passed.

If the container has no entrypoint, the command is executed directly.  As a result, this should be a transparent change for most use cases, while allowing the container's entrypoint to be used when present.

Reviewed-on: https://gitea.com/gitea/act/pulls/86
Reviewed-by: Jason Song <i@wolfogre.com>
Co-authored-by: Thomas E Lackey <telackey@bozemanpass.com>
Co-committed-by: Thomas E Lackey <telackey@bozemanpass.com>

pkg/runner/run_context.go

@@ -382,15 +382,15 @@ func (rc *RunContext) startJobContainer() common.Executor {
 							if err := rc.stopServiceContainers()(ctx); err != nil {
 								logger.Errorf("Error while cleaning services: %v", err)
 							}
-							if createAndDeleteNetwork {
+						}
-								// clean network if it has been created by act
+						if createAndDeleteNetwork {
-								// if using service containers
+							// clean network if it has been created by act
-								// it means that the network to which containers are connecting is created by `act_runner`,
+							// if using service containers
-								// so, we should remove the network at last.
+							// it means that the network to which containers are connecting is created by `act_runner`,
-								logger.Infof("Cleaning up network for job %s, and network name is: %s", rc.JobName, networkName)
+							// so, we should remove the network at last.
-								if err := container.NewDockerNetworkRemoveExecutor(networkName)(ctx); err != nil {
+							logger.Infof("Cleaning up network for job %s, and network name is: %s", rc.JobName, networkName)
-									logger.Errorf("Error while cleaning network: %v", err)
+							if err := container.NewDockerNetworkRemoveExecutor(networkName)(ctx); err != nil {
-								}
+								logger.Errorf("Error while cleaning network: %v", err)
 							}
 						}
 						return nil
@@ -410,8 +410,8 @@ func (rc *RunContext) startJobContainer() common.Executor {
 		jobContainerNetwork = networkName
 
 		rc.JobContainer = container.NewContainer(&container.NewContainerInput{
-			Cmd:            nil,
+			Cmd:            []string{"/bin/sleep", fmt.Sprint(rc.Config.ContainerMaxLifetime.Round(time.Second).Seconds())},
-			Entrypoint:     []string{"/bin/sleep", fmt.Sprint(rc.Config.ContainerMaxLifetime.Round(time.Second).Seconds())},
+			Entrypoint:     nil,
 			WorkingDir:     ext.ToContainerPath(rc.Config.Workdir),
 			Image:          image,
 			Username:       username,